pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464312615
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##########
@@ -618,7 +618,13 @@ public void testMultipleInserts() throws Exception {
dumpTableData(Table.ACIDTBL, 1, 1);
List<String> rs1 = runStatementOnDriver("select a,b from " + Table.ACIDTBL
+ " order by a,b");
Assert.assertEquals("Content didn't match after commit rs1", allData, rs1);
+ runStatementOnDriver("delete from " + Table.ACIDTBL + " where b = 2");
Review comment:
This is a valid test, but I think the testMultipleInserts test for
inserts, and this is test for deletes. Maybe create its' own test method named
testDeleteOfInserts like testUpdateOfInserts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
