vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464714632
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
##########
@@ -1619,6 +1620,9 @@ public static ColStatistics
getColStatisticsFromExpression(HiveConf conf, Statis
colName = enfd.getFieldName();
colType = enfd.getTypeString();
countDistincts = numRows;
+ } else if (end instanceof ExprDynamicParamDesc) {
+ //skip colecting stats for parameters
Review comment:
This method tries to figure out column statistics involved in the given
expression. I guess the stats are used by parent callers to do various
estimation like map join, aggregate min/max. For dynamic expression stats are
returned as null. I think it makes more sense to do what
`buildColStatForConstant` is doing and return an estimation instead of null. I
will update the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
