bmaidics commented on a change in pull request #1330: URL: https://github.com/apache/hive/pull/1330#discussion_r467007215
########## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ########## @@ -1861,6 +1861,19 @@ struct ScheduledQueryProgressInfo{ 4: optional string errorMessage, } +struct GetFileListRequest { + 1: optional string catName, + 2: optional string dbName, + 3: optional string tableName, + 4: optional list<string> partVals, + 6: optional string validWriteIdList +} + +struct GetFileListResponse { + 1: optional list<binary> fileListData, + 2: optional i32 fbVersionNumber Review comment: I agree. Here I wanted to express, that the version represents the fields in the flatbuffer file. In the first version, we'd like to store relative_path, length, last_modification_time, and file_format, but in future versions, we might want to add more fields. But you're right, this naming is confusing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org