kishendas commented on a change in pull request #1443:
URL: https://github.com/apache/hive/pull/1443#discussion_r481422408
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
##########
@@ -1227,4 +1232,13 @@ private TGetInfoResp getServerInfo(TGetInfoType type)
throws SQLException {
Utils.verifySuccess(resp.getStatus());
return resp;
}
+
+ private boolean getHiveDefaultNullsLast() {
+ boolean response = ConfVars.HIVE_DEFAULT_NULLS_LAST.defaultBoolVal;
Review comment:
@jcamachor @thejasmn Looks like we already open the session with HS2 in
HiveConnection, but when I see the OpenSession implementation in
ThriftCLIService, looks like we only send one HiveConf configuration :
resp.setConfiguration(Collections
.singletonMap(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_RESULTSET_DEFAULT_FETCH_SIZE.varname,
Integer.toString(fetchSize))); Should I add
HIVE_DEFAULT_NULLS_LAST here or we need to expose a new method ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
