pvary commented on a change in pull request #1220:
URL: https://github.com/apache/hive/pull/1220#discussion_r484757467
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
##########
@@ -727,35 +751,52 @@ private void testCheckExpectedLocks(boolean sharedWrite)
throws Exception {
*/
@Test
public void testCheckExpectedLocks2() throws Exception {
+ testCheckExpectedLocks2(true);
+ }
+ @Test
+ public void testCheckExpectedLocks2NoReadLock() throws Exception {
+ testCheckExpectedLocks2(false);
+ }
+ public void testCheckExpectedLocks2(boolean readLocks) throws Exception {
Review comment:
nit: new row
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java
##########
@@ -727,35 +751,52 @@ private void testCheckExpectedLocks(boolean sharedWrite)
throws Exception {
*/
@Test
public void testCheckExpectedLocks2() throws Exception {
+ testCheckExpectedLocks2(true);
+ }
+ @Test
Review comment:
nit: new row
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
