pvargacl commented on a change in pull request #1533:
URL: https://github.com/apache/hive/pull/1533#discussion_r496696581
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1408,6 +1410,43 @@ private boolean isUpdateOrDelete(Statement stmt, String
conflictSQLSuffix) throw
}
}
+ public long getLatestTxnInConflict(long txnid) throws MetaException {
Review comment:
Maybe add some javadoc, what does it do. I would emphasise that this
method call only makes sense if the caller holds an exclusive lock, that blocks
other txns to commit writes. And also, that this deliberately ignores inserts,
or maybe this should be added to the DriverTxnHandler, that inserts will not
invalidate the snapshot, that can cause duplicates
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
