yongzhi commented on a change in pull request #1559:
URL: https://github.com/apache/hive/pull/1559#discussion_r500535094
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -5213,11 +5213,13 @@ public LockHandle acquireLock(String key) throws
MetaException {
Connection dbConn = null;
Statement stmt = null;
ResultSet rs = null;
+ boolean needToCloseConn = false;
try {
try {
String sqlStmt = sqlGenerator.addForUpdateClause("SELECT
\"MT_COMMENT\" FROM \"AUX_TABLE\" WHERE \"MT_KEY1\"=" + quoteString(key) + "
and \"MT_KEY2\"=0");
lockInternal();
dbConn = getDbConn(Connection.TRANSACTION_READ_COMMITTED,
connPoolMutex);
+ needToCloseConn = true;
Review comment:
Yes, I checked every place that acquireLock is called, they are always
matching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
