pvargacl commented on a change in pull request #1618:
URL: https://github.com/apache/hive/pull/1618#discussion_r516488579
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
##########
@@ -344,6 +346,7 @@ public void markCleaned(CompactionInfo info) throws
MetaException {
rs = pStmt.executeQuery();
if (rs.next()) {
info = CompactionInfo.loadFullFromCompactionQueue(rs);
Review comment:
This code is quit weird. We should not read back the CompactionInfo from
the db, we could just use insert select for the COMPLETED_COMPACTIONS. The
other used fields later are already in the info passed by the Cleaner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
