yongzhi commented on a change in pull request #1590:
URL: https://github.com/apache/hive/pull/1590#discussion_r516202877
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
##########
@@ -254,6 +276,9 @@ CommandProcessorResponse compile(SessionState ss) throws
CommandProcessorExcepti
if (ss != null){
ss.add_resource(ResourceType.JAR, testArchive.getAbsolutePath());
+ try {
+ testArchive.deleteOnExit();
Review comment:
Then delete at exit should be fine.
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
##########
@@ -241,14 +254,26 @@ CommandProcessorResponse compile(SessionState ss) throws
CommandProcessorExcepti
out.closeArchiveEntry();
}
out.finish();
+ setPosixFilePermissions(testArchive, lockout, false);
Review comment:
What's the purpose of set the permission here? Could it happen before
the write operations above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
