kasakrisz opened a new pull request #1697:
URL: https://github.com/apache/hive/pull/1697
### What changes were proposed in this pull request?
1. When methods which shares the same implementation one of the method's
implementation is changed to call its pair. Ex.
```
public Frame decorrelateRel(HiveSortLimit rel) {
return decorrelateRel((Sort) rel);
}
public Frame decorrelateRel(Sort rel) {
...
```
2. Variations of `removeCorrelationExpr` has the same implementation only
difference was the number of parameters of the methods. This patch removes the
duplicates and variants which has fewer parameters calls the most specific and
pass default values for missing parameters.
### Why are the changes needed?
Decrease the amount of redundant code.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No functionality was altered. Execute some q tests which has subquery with
`in`, `exists` like `subquery_exists.q`, `subquery_in.q`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
