nrg4878 commented on a change in pull request #1761: URL: https://github.com/apache/hive/pull/1761#discussion_r541346293
########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ########## @@ -8556,6 +8556,9 @@ public UpdateMDatabaseURIRetVal updateMDatabaseURI(URI oldLoc, URI newLoc, boole updateLocations.put(locationURI.toString(), dbLoc); if (!dryRun) { mDB.setLocationUri(dbLoc); + if (org.apache.commons.lang3.StringUtils.isNotBlank(mDB.getManagedLocationUri())) { + mDB.setManagedLocationUri(dbLoc); Review comment: Looks like we are setting the value of locationURI for managedLocation. dbLoc is based on mDB.getLocationURI(). Instead we should have similar logic where string substitutions are performed on DB's managedlocation as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org