vihangk1 commented on a change in pull request #1791:
URL: https://github.com/apache/hive/pull/1791#discussion_r552276586



##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -592,6 +638,10 @@ public boolean retryRequest(IOException exception, int 
executionCount, HttpConte
       }
     });
 
+    if (isBrowserAuthMode()) {
+      httpClientBuilder

Review comment:
       This is however a good point. Having browser mode without cookie auth 
doesn't make sense. Since without cookie auth, each http call will open a 
browser (althought it will be automatically authenticated). I think for the 
first version may be we should disallow browser auth if cookie-auth is not 
enabled on the server side. Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to