vnhive commented on a change in pull request #1694:
URL: https://github.com/apache/hive/pull/1694#discussion_r553751705
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetExists.java
##########
@@ -555,6 +546,74 @@ public void
testGetTableObjectsWithProjectionOfMultiValuedFields() throws Except
}
}
+ @Test
+ public void testGetTableProjectionSpecification() throws Exception {
+ List<String> tableNames = new ArrayList<>();
+ tableNames.add(testTables[0].getTableName());
+ tableNames.add(testTables[1].getTableName());
+
+ GetProjectionsSpec projectSpec = (new GetTableProjectionsSpecBuilder())
+ .includeTableName()
+ .includeDatabase()
+ .includeSdCdColsName()
+ .includeSdCdColsType()
+ .includeSdCdColsComment()
+ .includeSdLocation()
+ .includeSdInputFormat()
+ .includeSdOutputFormat()
+ .includeSdIsCompressed()
+ .includeSdNumBuckets()
+ .includeSdSerDeInfoName()
+ .includeSdSerDeInfoSerializationLib()
+ .includeSdSerDeInfoParameters()
+ .includeSdSerDeInfoDescription()
+ .includeSdSerDeInfoSerializerClass()
+ .includeSdSerDeInfoDeserializerClass()
+ .includeSdSerDeInfoSerdeType()
+ .includeSdBucketCols()
+ .includeSdSortColsCol()
+ .includeSdSortColsOrder()
+ .includeSdparameters()
+ .includeSdSkewedColNames()
+ .includeSdSkewedColValues()
+ .includeSdSkewedColValueLocationMaps()
+ .includeSdIsStoredAsSubDirectories()
+ .includeOwner()
+ .includeOwnerType()
+ .includeCreateTime()
+ .includeLastAccessTime()
+ .includeRetention()
+ .includePartitionKeysName()
+ .includePartitionKeysType()
+ .includePartitionKeysComment()
+ .includeParameters()
+ .includeViewOriginalText()
+ .includeRewriteEnabled()
+ .includeTableType()
+ .build();
+
+ List<Table> tables = client.getTables(null, DEFAULT_DATABASE, tableNames,
projectSpec);
+
+ Assert.assertEquals("Found tables", 2, tables.size());
+
+ for(Table table : tables) {
+ Assert.assertTrue(table.isSetDbName());
+ Assert.assertTrue(table.isSetCatName());
+ Assert.assertTrue(table.isSetTableName());
+ Assert.assertTrue(table.isSetLastAccessTime());
+ Assert.assertTrue(table.isSetSd());
+ StorageDescriptor sd = table.getSd();
+ Assert.assertTrue(sd.isSetCols());
+ Assert.assertTrue(sd.isSetSerdeInfo());
+ Assert.assertTrue(sd.isSetBucketCols());
+ Assert.assertTrue(sd.isSetCompressed());
+ Assert.assertTrue(sd.isSetInputFormat());
+ Assert.assertTrue(sd.isSetSerdeInfo());
+ SerDeInfo serDeInfo = sd.getSerdeInfo();
+ Assert.assertTrue(serDeInfo.isSetSerializationLib());
+ }
+ }
+
Review comment:
Done. I had changed all the test cases to use the builder methods these
test negations also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
