kasakrisz opened a new pull request #1869: URL: https://github.com/apache/hive/pull/1869
### What changes were proposed in this pull request? 1. Move the `valuesSource` rule alternative from `queryStatementExpression` parser rule to `atomSelectStatement` 2. Remove `valuesClause` rule alternative from `regularBody` since it is covered through `selectStatement`->`atomSelectStatement`->`valuesSource`->`valuesClause` ### Why are the changes needed? Enable queries which has values clause as operand of set operation. See jira or `values.q` for example ### Does this PR introduce _any_ user-facing change? Yes. Users can write queries which has values clause as operand of set operation. This feature was not enabled in the past and Hive thrown exception such cases. Existing queries are not affected. ### How was this patch tested? ``` mvn test -Dtest=TestValuesClause -pl parser mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=values.q -pl itests/qtest -Pitests ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
