pvary commented on a change in pull request #1881:
URL: https://github.com/apache/hive/pull/1881#discussion_r560072484
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -102,11 +102,16 @@ public void run() {
ExecutorService executor = getTimeoutHandlingExecutor();
try {
do {
- Future<Boolean> singleRun = executor.submit(() ->
findNextCompactionAndExecute(computeStats));
+ Ref<CompactionInfo> ci = new Ref<>(null);
+ Future<Boolean> singleRun = executor.submit(() ->
findNextCompactionAndExecute(computeStats, ci));
Review comment:
Wouldn't it be more natural to have a complex return type, like below?
Definitely not a final proposal just some food for thought.
```
private static class ExecutionResult {
private Boolean singleRun;
private CompactionInfo failedCompaction;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
