pvargacl commented on a change in pull request #1893:
URL: https://github.com/apache/hive/pull/1893#discussion_r561044735
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -2620,18 +2622,18 @@ public static void listFilesInsideAcidDirectory(Path
acidDir, FileSystem srcFs,
}
}
- private void listFilesCreatedByQuery(Path loadPath, long writeId, int
stmtId, boolean isInsertOverwrite,
- List<Path> newFiles) throws HiveException {
+ private List<FileStatus> listFilesCreatedByQuery(Path loadPath, long
writeId, int stmtId) throws HiveException {
Review comment:
No, we need the filestatuses, so we can reuse them later for populating
the quickstats. In a follow up patch I will try to do the other way around and
collect FileStatus everywhere in loadPartition instead of Path, because
writeNotification could also benefit having the filestatuses ready. But it is
not that trivial change in the non direct insert cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
