zeroflag commented on a change in pull request #1733:
URL: https://github.com/apache/hive/pull/1733#discussion_r565420580
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2856,6 +2876,11 @@ PartitionsResponse
get_partitions_req(1:PartitionsRequest req)
StoredProcedure get_stored_procedure(1: StoredProcedureRequest request)
throws (1:MetaException o1, 2:NoSuchObjectException o2)
void drop_stored_procedure(1: StoredProcedureRequest request) throws
(1:MetaException o1, 2:NoSuchObjectException o2)
list<string> get_all_stored_procedures(1: ListStoredProcedureRequest
request) throws (1:MetaException o1)
+
+ Package find_package(1: PackageRequest request) throws (1:MetaException o1)
Review comment:
This was requested in an earlier review to follow this convention at
every thrift method. The rational behind it is that it allows making compatible
changes (adding new fields into PackageRequest) easier without touching the
signature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
