pgaref commented on a change in pull request #1726:
URL: https://github.com/apache/hive/pull/1726#discussion_r566096110
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
##########
@@ -132,6 +130,14 @@ public Object getLiteral() {
return literalList;
}
+ public int getId() {
Review comment:
I believe **Id** setter and getter could be moved to the
**PredicateLeaf** interface.
It would be cleaner and as a result **addLeaf** would need less
modifications.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
