kasakrisz commented on a change in pull request #1892:
URL: https://github.com/apache/hive/pull/1892#discussion_r566648716
##########
File path: parser/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g
##########
@@ -151,11 +182,46 @@ expressionsNotInParenthesis[boolean isStruct, boolean
forceStruct]
-> {$more.tree}
;
-expressionPart[CommonTree t, boolean isStruct]
+expressionPart[CommonTree firstExprTree, boolean isStruct]
:
(COMMA expression)+
- -> {isStruct}? ^(TOK_FUNCTION Identifier["struct"] {$t} expression+)
- -> {$t} expression+
+ -> {isStruct}? ^(TOK_FUNCTION Identifier["struct"] {$firstExprTree}
expression+)
+ -> {$firstExprTree} expression+
+ ;
+
+// Parses comma separated list of expressions with optionally specified
aliases and store the aliases for further usage.
+// <expression> [<alias>] [, <expression> [<alias>]]
+firstExpressionsWithAlias
+@init { initAliases(); }
+ :
+ first=expression colAlias=identifier? (COMMA expressionWithAlias)*
+ -> {colAlias != null}? ^(TOK_FUNCTION Identifier["named_struct"] {
adaptor.create(Identifier, addAlias($colAlias.tree.getText())) } {$first.tree}
expressionWithAlias*)
Review comment:
I removed the `name_struct` approach and developed a different one using
`struct` and a new toke to identify aliases. This required some additional
functionality in the `TypeCheckProcFactory`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
