abstractdog commented on a change in pull request #1941:
URL: https://github.com/apache/hive/pull/1941#discussion_r570366496
##########
File path:
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
##########
@@ -446,16 +478,23 @@ public void shutdown() throws IOException {
@Override
public void setupConfiguration(Configuration conf) {
Configuration config = mr.getConfig();
- for (Map.Entry<String, String> pair: config) {
+ for (Map.Entry<String, String> pair : config) {
Review comment:
not, but it's autoformatted by eclipse, actually I liked the change, I
always put spaces before and after colon in iterations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
