deniskuzZ commented on a change in pull request #1834:
URL: https://github.com/apache/hive/pull/1834#discussion_r570556176
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -4797,6 +4800,84 @@ private void heartbeatTxn(Connection dbConn, long txnid)
}
}
+ private boolean foundCommittedTransaction(Connection dbConn, long txnId,
FindStatStatusByWriteIdRequest rqst,
+ String condition) throws
SQLException, MetaException {
+ String s = sqlGenerator.addLimitClause(1,
+ "1 FROM \"COMPLETED_TXN_COMPONENTS\" WHERE \"CTC_TXNID\" " +
condition + " " + txnId +
+ " AND \"CTC_DATABASE\" = ? AND \"CTC_TABLE\" = ?");
Review comment:
you do not need db and table filters as txnid is unique across them, see
findTxnState
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]