deniskuzZ commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576703148
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -469,6 +469,12 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
ShowCompactResponse c
"=true so we will not compact it.");
return false;
}
+ if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf
Review comment:
Just my thought on that, feel free to ignore them:
If something is already there doesn't mean it's a good practice. The
presence of a switch just indicates how unreliable compaction functionality is
that we still need to maintain feature flag.
Do we have similar toggle just for MR based compaction? :)
Until the upgrade they should probably avoid using MM tables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
