soumyakanti3578 commented on a change in pull request #1959:
URL: https://github.com/apache/hive/pull/1959#discussion_r578878891
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java
##########
@@ -143,40 +144,24 @@ public RelNode createFilter(RelNode child, RexNode
condition, Set<CorrelationId>
* Right input
* @param condition
* Join condition
- * @param joinType
- * Join type
- * @param variablesStopped
+ * @param variablesStoppedd
* Set of names of variables which are set by the LHS and used by
* the RHS and are not available to nodes above this JoinRel in
the
* tree
+ *@param joinType
+ * Join type
* @param semiJoinDone
* Whether this join has been translated to a semi-join
*/
@Override
- public RelNode createJoin(RelNode left, RelNode right, RexNode condition,
JoinRelType joinType,
- Set<String> variablesStopped, boolean semiJoinDone) {
+ public RelNode createJoin(RelNode left, RelNode right, List<RelHint>
hints, RexNode condition,
+ Set<CorrelationId> variablesStoppedd, JoinRelType joinType, boolean
semiJoinDone) {
if (joinType == JoinRelType.SEMI) {
final RelOptCluster cluster = left.getCluster();
return HiveSemiJoin.getSemiJoin(cluster, left.getTraitSet(), left,
right, condition);
}
return HiveJoin.getJoin(left.getCluster(), left, right, condition,
joinType);
}
-
- @Override
- public RelNode createJoin(RelNode left, RelNode right, RexNode condition,
- Set<CorrelationId> variablesSet, JoinRelType joinType, boolean
semiJoinDone) {
- // According to calcite, it is going to be removed before Calcite-2.0
- // TODO: to handle CorrelationId
- if (joinType == JoinRelType.SEMI) {
- final RelOptCluster cluster = left.getCluster();
- return HiveSemiJoin.getSemiJoin(cluster, left.getTraitSet(), left,
right, condition);
- }
- if (joinType == JoinRelType.ANTI) {
Review comment:
Added another `if` block for AntiJoin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
