ArkoSharma commented on a change in pull request #1936:
URL: https://github.com/apache/hive/pull/1936#discussion_r582431197
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTablesMetaDataOnly.java
##########
@@ -103,9 +102,9 @@ public void replicationWithoutExternalTables() throws
Throwable {
.run("insert into table t2 partition(country='france') values
('paris')")
.dump(primaryDbName, dumpWithClause);
- // the _external_tables_file info only should be created if external
tables are to be replicated not otherwise
- assertFalse(primary.miniDFSCluster.getFileSystem()
- .exists(new Path(new Path(tuple.dumpLocation,
primaryDbName.toLowerCase()), FILE_NAME)));
+ // the _file_list_external only should be created if external tables are
to be replicated not otherwise
+ assertFalseExternalFileList(new Path(new Path(tuple.dumpLocation,
Review comment:
Removing would cause code-duplication in most places, except in
TestReplicationScenariosExternalTablesMetaDataOnly.java . Refactored the code
there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
