pvary commented on a change in pull request #2040:
URL: https://github.com/apache/hive/pull/2040#discussion_r589248926
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordReader.java
##########
@@ -88,22 +88,39 @@ public AvroGenericRecordReader(JobConf job, FileSplit
split, Reporter reporter)
gdr.setExpected(latest);
}
- if (split.getLength() == 0) {
- this.isEmptyInput = true;
- this.start = 0;
- this.reader = null;
+ org.apache.avro.file.FileReader<GenericRecord> nonFinalReader = null;
+ try {
Review comment:
Can we put this `try` to the `else` only?
Maybe even try with resources if the reader is autoclosable, like
```
try (org.apache.avro.file.FileReader<GenericRecord> nonFinalReader = new
DataFileReader<GenericRecord>(new FsInput(split.getPath(), job), gdr)) {
[..]
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
