deniskuzZ commented on pull request #2052: URL: https://github.com/apache/hive/pull/2052#issuecomment-793679004
> > @klcopp, with [HIVE-24179](https://issues.apache.org/jira/browse/HIVE-24179) heartbeatExecutorService was made to be a global to avoid multiple shutdown hooks for the same threadpool. cc @zabetak > > Thanks for catching this @deniskuzZ! > > Strange thing that the service is static, but not initialized in a static way. > The first user might set the pool size to a small one, and then later ones can not change it... Is there any particular reason behind this? I don't think we should allow to change this config at session level. Idea was to have a single threadpool for txn heartbeating job. Btw initialization is also under the static method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
