kasakrisz opened a new pull request #2060: URL: https://github.com/apache/hive/pull/2060
### What changes were proposed in this pull request? 1. Introduce RESPECT NULLS IGNORE NULLS syntax and add it to `TOK_WINDOWSPEC` tree 2. Add ignoreNulls property to `WindowingSpec` and set it in `SemanticAnalyzer` during AST traversal. 3. Set ignoreNull property in `RexOver` in Calcite plan. 4. Add true literal `ASTNode` as an extra parameter of window function in `ASTConverter` when transforming back Calcite plan to AST. first/last_value functions already supports this extra parameter. ### Why are the changes needed? Support specifying ignore nulls in a standard way. ### Does this PR introduce _any_ user-facing change? Yes, but existing behavior not changed. Ignore nulls can be specified two ways: ``` Standard: select last_value(b) ignore nulls over Legacy: select last_value(b, true) over ``` ### How was this patch tested? ``` mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=windowing_navfn.q -pl itests/qtest -Pitests ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
