kgyrtkirk commented on a change in pull request #1959:
URL: https://github.com/apache/hive/pull/1959#discussion_r592197745
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java
##########
@@ -158,7 +158,6 @@ public static SqlAggFunction getRollup(SqlAggFunction
aggregation) {
return null;
}
- @Override
Review comment:
CALCITE-3774 have removed this method - and replaced it with
`config.bloat()`
as the comment suggests this feature caused incorrectly merged `Project`-s
which contained `Over` expressions
* the new code have this bloat enabled by default with 100
* since the new check seems is heuristic based - it may not happen by default
I'm not sure if our issue is gone now or not - setting bloat to `-1` might
be a way to disable this; and consider enabling it later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
