pvargacl commented on a change in pull request #2061:
URL: https://github.com/apache/hive/pull/2061#discussion_r592290451
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -171,9 +176,12 @@ public void run() {
StringUtils.stringifyException(t));
}
finally {
- if(handle != null) {
+ if (handle != null) {
handle.releaseLocks();
}
+ if (metricsEnabled) {
Review comment:
Won't this fail, if the acquireLock times out and the perflogger was not
started? The PerfLogger in ql has a method for checking this
startTimeHasMethod, maybe it worth to copy that and use it here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
