pvargacl commented on a change in pull request #2062:
URL: https://github.com/apache/hive/pull/2062#discussion_r595001156



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -97,12 +99,14 @@ public static String hostname() {
   public void run() {
     LOG.info("Starting Worker thread");
     boolean computeStats = 
conf.getBoolVar(HiveConf.ConfVars.HIVE_MR_COMPACTOR_GATHER_STATS);
+    boolean metricsEnabled = 
conf.getBoolVar(HiveConf.ConfVars.HIVE_SERVER2_METRICS_ENABLED);

Review comment:
       I didn't see anywhere in HS2 to check this property before using 
perflogger, the metricsfactory will be disabled globally if this is not 
enabled. You can remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to