pvargacl commented on a change in pull request #2079:
URL: https://github.com/apache/hive/pull/2079#discussion_r595971033
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -156,11 +144,17 @@ private void verifyTableIdHasNotChanged(CompactionInfo
ci, Table originalTable)
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
- StringBuilder name = new StringBuilder(hostname());
+ StringBuilder name = new StringBuilder(ServerUtils.hostname());
name.append("-");
name.append(getId());
this.workerName = name.toString();
setName(name.toString());
+ this.runtimeVersion = getRuntimeVersion();
+ }
+
+ @VisibleForTesting
+ protected String getRuntimeVersion() {
Review comment:
moved the runtimeVersion and host setup to CompactorThread
##########
File path:
ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java
##########
@@ -86,14 +86,14 @@ public void testFindNextToCompact() throws Exception {
rqst.setPartitionname("ds=today");
txnHandler.compact(rqst);
long now = System.currentTimeMillis();
- CompactionInfo ci = txnHandler.findNextToCompact("fred");
+ CompactionInfo ci = txnHandler.findNextToCompact("fred", "4.0.0");
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
