aasha commented on a change in pull request #2068:
URL: https://github.com/apache/hive/pull/2068#discussion_r598247086
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -5086,8 +5093,10 @@ public void performTimeOuts() {
while(true) {
stmt = dbConn.createStatement();
String s = " \"TXN_ID\" FROM \"TXNS\" WHERE \"TXN_STATE\" = " +
TxnStatus.OPEN +
- " AND \"TXN_LAST_HEARTBEAT\" < " + getEpochFn(dbProduct) + "-" +
timeout +
- " AND \"TXN_TYPE\" != " + TxnType.REPL_CREATED.getValue();
+ " AND \"TXN_LAST_HEARTBEAT\" < " + getEpochFn(dbProduct) + "-" +
+ (replication ? replicationTxnTimeout : timeout) +
+ " AND \"TXN_TYPE\" " +
Review comment:
TXN_TYPE will always be REPL_CREATED for replication. This check looks
incorrect.
It could be something like if txn type is REPL_CREATED, use
replicationTxnTimeout else timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
