zeroflag commented on a change in pull request #2059:
URL: https://github.com/apache/hive/pull/2059#discussion_r598793037



##########
File path: hplsql/src/main/java/org/apache/hive/hplsql/Exec.java
##########
@@ -974,14 +990,16 @@ void cleanup() {
   void printExceptions() {
     while (!signals.empty()) {
       Signal sig = signals.pop();
-      if (sig.type == Signal.Type.SQLEXCEPTION) {
+      if (sig.type == Signal.Type.VALIDATION) {

Review comment:
       i'm not fully sure about NOTFOUND but that's probably not considered as 
an error, it is signaled when select doesn't produce a result which can be 
normal. The UNSUPPORTED_OPERATION was handled implicitly by sig.value != null. 
I added an explicit case for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to