pkumarsinha commented on a change in pull request #2097:
URL: https://github.com/apache/hive/pull/2097#discussion_r603748637
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -414,7 +441,8 @@ private boolean shouldDump(Path previousDumpPath) throws
IOException {
return true;
} else {
FileSystem fs = previousDumpPath.getFileSystem(conf);
- return fs.exists(new Path(previousDumpPath,
LOAD_ACKNOWLEDGEMENT.toString()));
+ return fs.exists(new Path(previousDumpPath,
LOAD_ACKNOWLEDGEMENT.toString()))
+ && !fs.exists(new Path(previousDumpPath,
FAILOVER_READY_MARKER.toString()));
Review comment:
If the skip is because of failover, we should also also ensure if there
is no open write txn at this point of time and if found one, we should fail the
policy with irrecoverable error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
