deniskuzZ commented on a change in pull request #2132:
URL: https://github.com/apache/hive/pull/2132#discussion_r604049457



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/MetricsConstants.java
##########
@@ -27,6 +27,11 @@
   public static final String COMPACTION_WORKER_CYCLE = 
"compaction_worker_cycle";
   public static final String OLDEST_OPEN_TXN_ID = "oldest_open_txn_id";
   public static final String OLDEST_OPEN_TXN_AGE = 
"oldest_open_txn_age_in_sec";
+  // number of aborted txns in TXNS table
+  public static final String NUM_ABORTED_TXNS_IN_TXNS = 
COMPACTION_STATUS_PREFIX + "aborted_txns_in_txns";
+  public static final String OLDEST_ABORTED_TXN_ID = "oldest_aborted_txn_id";
+  public static final String OLDEST_ABORTED_TXN_AGE_IN_SEC = 
"oldest_aborted_txn_age_in_sec";

Review comment:
       could we please use consistent naming? should we modify 
OLDEST_OPEN_TXN_AGE -> OLDEST_OPEN_TXN_AGE_IN_SEC? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to