nrg4878 commented on a change in pull request #2037:
URL: https://github.com/apache/hive/pull/2037#discussion_r606347304
##########
File path: parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -1106,14 +1126,16 @@ orReplace
createDatabaseStatement
@init { pushMsg("create database statement", state); }
@after { popMsg(state); }
- : KW_CREATE (KW_DATABASE|KW_SCHEMA)
+ : KW_CREATE (remote=KW_REMOTE)? (KW_DATABASE|KW_SCHEMA)
ifNotExists?
name=identifier
databaseComment?
dbLocation?
dbManagedLocation?
+ dbConnectorName?
(KW_WITH KW_DBPROPERTIES dbprops=dbProperties)?
- -> ^(TOK_CREATEDATABASE $name ifNotExists? dbLocation? dbManagedLocation?
databaseComment? $dbprops?)
+ -> {$remote != null}? ^(TOK_CREATEDATABASE $name ifNotExists?
databaseComment? $dbprops? dbConnectorName?)
Review comment:
we don't support create/drop/alter in REMOTE databases at this point.
the concepts of managed vs external is not in the picture at this point. When
we do support it, it will be application to the hive connectors only (or other
hive based connectors like AWS Glue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
