kishendas commented on a change in pull request #2153:
URL: https://github.com/apache/hive/pull/2153#discussion_r608153724
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -2367,10 +2367,21 @@ public Table getTable(String catName, String dbName,
String tableName,
return getTable(catName, dbName, tableName, validWriteIdList, false, null);
}
+ @Override
+ public Table getTable(String catName, String dbName, String tableName,
Review comment:
It makes sense to just use GetTableResult
get_table_req(1:GetTableRequest req) throws (1:MetaException o1,
2:NoSuchObjectException o2) and redirect all the other variations to use this
method, so that you don't have to add tableId in all the other variations.
Ideally we should deprecate and remove all the methods that doesn't take
Request object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
