marton-bod commented on pull request #2138: URL: https://github.com/apache/hive/pull/2138#issuecomment-816589194
> Generally looks good to me. > A few nits only. Did we remove all the "hacks" we did for the iceberg-handler module which were needed until we have the metastore module? Thanks for the review! Yes, the only hack we could remove with this one was this: https://github.com/apache/hive/pull/2138/files#diff-9d31f72cca8ab08ae120d321c1b58816336936a23a4ef720ad65e79d3acbe743L357 Most other hacks depend on Iceberg 0.12.0 coming out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
