pvary commented on a change in pull request #2137:
URL: https://github.com/apache/hive/pull/2137#discussion_r611535475
##########
File path:
iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -250,4 +305,74 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
// this is an exception to the interface documentation, but it's a safe
operation to add this property
props.put(InputFormatConfig.TABLE_SCHEMA, schemaJson);
}
+
+ /**
+ * Recursively collects the column names from the predicate.
+ * @param node The node we are traversing
+ * @param columns The already collected column names
+ */
+ private void columns(ExprNodeDesc node, Collection<String> columns) {
Review comment:
Based on my tests the `addDynamicSplitPruningEdge` will be called for
every column and the `ExprNodeDesc` only refers to a single column, so in
theory we can handle multiple columns and everything, but we do not have to
optimize for multi-column case. Using `Set` would work as well, but it is more
strict and I wanted to keep things as general as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
