vihangk1 commented on a change in pull request #2171: URL: https://github.com/apache/hive/pull/2171#discussion_r611953064
########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/AbstractThriftHiveMetastore.java ########## @@ -0,0 +1,1336 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore; + +import com.facebook.fb303.fb_status; +import org.apache.hadoop.hive.metastore.api.*; +import org.apache.hadoop.hive.metastore.api.Package; +import org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore.Iface; +import org.apache.thrift.TException; + +import java.util.List; +import java.util.Map; + +/** + * This abstract class can be extended by any remote cache that implements HMS APIs. + * The idea behind introducing this abstract class is not to break the build of remote cache, + * whenever we add new HMS APIs. + */ +public abstract class AbstractThriftHiveMetastore implements Iface { + + @Override public String getMetaConf(String key) throws MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void setMetaConf(String key, String value) throws MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void create_catalog(CreateCatalogRequest catalog) + throws AlreadyExistsException, InvalidObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void alter_catalog(AlterCatalogRequest rqst) + throws NoSuchObjectException, InvalidOperationException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public GetCatalogResponse get_catalog(GetCatalogRequest catName) + throws NoSuchObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public GetCatalogsResponse get_catalogs() throws MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void drop_catalog(DropCatalogRequest catName) + throws NoSuchObjectException, InvalidOperationException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void create_database(Database database) + throws AlreadyExistsException, InvalidObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public Database get_database(String name) throws NoSuchObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public Database get_database_req(GetDatabaseRequest request) + throws NoSuchObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void drop_database(String name, boolean deleteData, boolean cascade) + throws NoSuchObjectException, InvalidOperationException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public List<String> get_databases(String pattern) throws MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public List<String> get_all_databases() throws MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void alter_database(String dbname, Database db) + throws MetaException, NoSuchObjectException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void create_dataconnector(DataConnector connector) + throws AlreadyExistsException, InvalidObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public DataConnector get_dataconnector_req(GetDataConnectorRequest request) + throws NoSuchObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void drop_dataconnector(String name, boolean ifNotExists, boolean checkReferences) + throws NoSuchObjectException, InvalidOperationException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public List<String> get_dataconnectors() throws MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void alter_dataconnector(String name, DataConnector connector) + throws MetaException, NoSuchObjectException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public Type get_type(String name) throws MetaException, NoSuchObjectException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public boolean create_type(Type type) + throws AlreadyExistsException, InvalidObjectException, MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public boolean drop_type(String type) throws MetaException, NoSuchObjectException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public Map<String, Type> get_type_all(String name) throws MetaException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public List<FieldSchema> get_fields(String db_name, String table_name) + throws MetaException, UnknownTableException, UnknownDBException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public List<FieldSchema> get_fields_with_environment_context(String db_name, String table_name, + EnvironmentContext environment_context) + throws MetaException, UnknownTableException, UnknownDBException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public GetFieldsResponse get_fields_req(GetFieldsRequest req) + throws MetaException, UnknownTableException, UnknownDBException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public List<FieldSchema> get_schema(String db_name, String table_name) + throws MetaException, UnknownTableException, UnknownDBException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public List<FieldSchema> get_schema_with_environment_context(String db_name, String table_name, + EnvironmentContext environment_context) + throws MetaException, UnknownTableException, UnknownDBException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public GetSchemaResponse get_schema_req(GetSchemaRequest req) + throws MetaException, UnknownTableException, UnknownDBException, TException { + throw new UnsupportedOperationException("this method is not supported"); + } + + @Override public void create_table(Table tbl) Review comment: The @Override is inline in all the methods. May be just reformat the file with your IDE so that it is in line with the rest of the code style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
