pvary commented on a change in pull request #2169:
URL: https://github.com/apache/hive/pull/2169#discussion_r612556987
##########
File path: pom.xml
##########
@@ -64,8 +64,7 @@
<module>standalone-metastore</module>
<module>upgrade-acid</module>
<module>kafka-handler</module>
- <module>iceberg-handler</module>
- <module>iceberg-catalog</module>
+ <module>iceberg</module>
Review comment:
Applied my other patches so there is a new class in
`patched-iceberg-api` (`CommitStateUnknownException`)
Run the packaging and checked the `packaging/target/.../lib` and it still
contains the libs:
```
$ cd
packaging/target/apache-hive-4.0.0-SNAPSHOT-bin/apache-hive-4.0.0-SNAPSHOT-bin/
$ ls *iceberg*
hive-iceberg-catalog-4.0.0-SNAPSHOT.jar
hive-iceberg-handler-4.0.0-SNAPSHOT.jar
```
The new class is in the jar:
```
$ zip -sf hive-iceberg-handler-4.0.0-SNAPSHOT.jar |grep
CommitStateUnknownException
org/apache/hive/iceberg/org/apache/iceberg/exceptions/CommitStateUnknownException.class
```
So this seems ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
