pgaref commented on a change in pull request #2123:
URL: https://github.com/apache/hive/pull/2123#discussion_r612766954
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -429,6 +437,11 @@ public LlapTaskSchedulerService(TaskSchedulerContext
taskSchedulerContext, Clock
delayedTaskSchedulerExecutor =
MoreExecutors.listeningDecorator(delayedTaskSchedulerExecutorRaw);
+ ExecutorService preemptTaskSchedulerExecutorRaw =
Executors.newFixedThreadPool(1,
Review comment:
Well, I agree but the actual LLAP preemption Conf we are using
https://github.com/apache/hive/blob/61d5c641b2e414c7b7dfd92f2b402db3583507c8/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L5023
is actually targeting the TaskExecutorService within the LlapDaemon
(waitQueue tasks vs Running) and not the LlapTaskSchedulingService -- in a
sense this a different type of preemption and I am not sure we should just use
the same conf here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
