aasha commented on a change in pull request #2197:
URL: https://github.com/apache/hive/pull/2197#discussion_r618959413
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -671,10 +672,14 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
Path dbRootData = new Path(bootstrapRoot, EximUtil.DATA_PATH_NAME +
File.separator + dbName);
boolean dataCopyAtLoad =
conf.getBoolVar(HiveConf.ConfVars.REPL_RUN_DATA_COPY_TASKS_ON_TARGET);
ReplExternalTables externalTablesWriter = new ReplExternalTables(conf);
- Path dbPath = null;
boolean isSingleCopyTaskForExternalTables =
- conf.getBoolVar(REPL_EXTERNAL_WAREHOUSE_SINGLE_COPY_TASK)
- && work.replScope.includeAllTables();
+ conf.getBoolVar(REPL_EXTERNAL_WAREHOUSE_SINGLE_COPY_TASK) &&
work.replScope.includeAllTables();
+ ArrayList<String> singleCopyPaths = new ArrayList<>();
+ if (db != null && isSingleCopyTaskForExternalTables) {
Review comment:
can be added as a util
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplExternalTables.java
##########
@@ -114,11 +112,27 @@ void dataLocationDump(Table table, FileList fileList,
}
}
- void dbLocationDump(String dbName, Path dbLocation, FileList fileList,
- HiveConf conf) throws Exception {
- Path fullyQualifiedDataLocation = PathBuilder
- .fullyQualifiedHDFSUri(dbLocation, FileSystem.get(hiveConf));
- dirLocationToCopy(dbName, fileList, fullyQualifiedDataLocation, conf);
+ void singleLocationsDump(List<String> singlePathLocations, FileList
fileList, HiveConf conf) throws Exception {
Review comment:
nit : can rename the method to something more intuitive. or add comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
