pvary commented on a change in pull request #2243:
URL: https://github.com/apache/hive/pull/2243#discussion_r633488104
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java
##########
@@ -216,6 +216,9 @@ private HiveConf initializeConf() {
// enables vectorization on Tez
hiveConf.set("tez.mrreader.config.update.properties",
"hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids");
+ // set lifecycle hooks
+ hiveConf.setVar(HiveConf.ConfVars.HIVE_QUERY_LIFETIME_HOOKS,
HiveIcebergCTASHook.class.getName());
Review comment:
I have seen another Iceberg hook already. Maybe we would like to keep
them as a single class?
Maybe even if they are implementing different interfaces? - Just an idea
which I am playing around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
