marton-bod commented on a change in pull request #2243:
URL: https://github.com/apache/hive/pull/2243#discussion_r634434118
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -514,6 +519,75 @@ public void testInsertOverwritePartitionedTable() throws
IOException {
HiveIcebergTestUtils.validateData(table, expected, 0);
}
+ @Test
+ public void testCTASFromHiveTable() {
+ Assume.assumeTrue("CTAS target table is supported only for HiveCatalog
tables",
+ testTableType == TestTables.TestTableType.HIVE_CATALOG);
Review comment:
Nothing in principle, we could use CTAS with other catalogs as well. For
some reason it was more difficult to create the table from the serDe for other
catalogs because some properties like location/warehouseLocation were missing.
And I also thought that we wouldn't really want to create tables outside of the
HiveCatalog anyway. But I can take another look for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
