pgaref commented on a change in pull request #2300:
URL: https://github.com/apache/hive/pull/2300#discussion_r635892282
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/WriteBuffers.java
##########
@@ -149,7 +149,12 @@ public int unsafeHashCode(long offset, int length) {
}
public int hashCode(long offset, int length, Position readPos) {
+ // If caller has not set the read position, then set it.
setReadPoint(offset, readPos);
+ return hashCode(length, readPos);
Review comment:
Shall we move the positioning code to the unsafeHashCode method and
remove this method? Looks like the only place its needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
