marton-bod commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r642497632
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -151,7 +152,23 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
private void createTableForCTAS(Configuration configuration, Properties
serDeProperties) {
serDeProperties.setProperty(TableProperties.ENGINE_HIVE_ENABLED, "true");
serDeProperties.setProperty(InputFormatConfig.TABLE_SCHEMA,
SchemaParser.toJson(tableSchema));
+
+ // build partition spec, if any
+ if (serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS) !=
null) {
+ String[] partCols =
serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS).split(",");
Review comment:
After some digging, it seems that column names can indeed contain `,`.
If they do, Hive will use a different delimiter. I've fixed the serDe code to
take that into account.
However, right now Iceberg tables do not handle having column names with a
comma very well (those tables can be created but can't be read back), so that
is something that should be addressed in a separate PR. I've filed a jira for
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
