pvary commented on a change in pull request #2347:
URL: https://github.com/apache/hive/pull/2347#discussion_r644899221
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -437,19 +438,13 @@ public void
commitInsertTable(org.apache.hadoop.hive.metastore.api.Table table,
throws MetaException {
String tableName = TableIdentifier.of(table.getDbName(),
table.getTableName()).toString();
JobContext jobContext = getJobContextForCommitOrAbort(tableName,
overwrite);
- boolean failure = false;
- try {
- OutputCommitter committer = new HiveIcebergOutputCommitter();
- committer.commitJob(jobContext);
- } catch (Exception e) {
- failure = true;
- LOG.error("Error while trying to commit job", e);
- throw new MetaException(StringUtils.stringifyException(e));
- } finally {
- // if there's a failure, the configs will still be needed in
rollbackInsertTable
- if (!failure) {
- // avoid config pollution with prefixed/suffixed keys
- cleanCommitConfig(tableName);
+ if (jobContext != null) {
Review comment:
Oh... I found the reason behind it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
