marton-bod commented on a change in pull request #2348:
URL: https://github.com/apache/hive/pull/2348#discussion_r645506912
##########
File path: parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -1971,10 +1971,12 @@ tableFileFormat
-> ^(TOK_TABLEFILEFORMAT $inFmt $outFmt $inDriver? $outDriver?)
| KW_STORED KW_BY storageHandler=StringLiteral
(KW_WITH KW_SERDEPROPERTIES serdeprops=tableProperties)?
- -> ^(TOK_STORAGEHANDLER $storageHandler $serdeprops?)
+ (KW_STORED KW_AS fileformat=identifier)?
Review comment:
Does this mean we will now enable STORED BY and STORED AS in the same
query for all storage handlers, like Kudu, Kafka, etc? Do we expect them to
break as a result, e.g. if saying something like `stored by kudu stored as
orc`? In addition, I guess we should update the Hive language manual too after
this change to signify that stored as/stored by are not mutually exclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
