pvary commented on a change in pull request #2376: URL: https://github.com/apache/hive/pull/2376#discussion_r649387084
########## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestPartitionStat.java ########## @@ -0,0 +1,242 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.metastore.client; + +import org.apache.hadoop.hive.metastore.IMetaStoreClient; +import org.apache.hadoop.hive.metastore.annotation.MetastoreCheckinTest; +import org.apache.hadoop.hive.metastore.api.ColumnStatistics; +import org.apache.hadoop.hive.metastore.api.ColumnStatisticsData; +import org.apache.hadoop.hive.metastore.api.ColumnStatisticsDesc; +import org.apache.hadoop.hive.metastore.api.ColumnStatisticsObj; +import org.apache.hadoop.hive.metastore.api.Database; +import org.apache.hadoop.hive.metastore.api.FieldSchema; +import org.apache.hadoop.hive.metastore.api.LongColumnStatsData; +import org.apache.hadoop.hive.metastore.api.Partition; +import org.apache.hadoop.hive.metastore.api.SetPartitionsStatsRequest; +import org.apache.hadoop.hive.metastore.api.Table; +import org.apache.hadoop.hive.metastore.client.builder.DatabaseBuilder; +import org.apache.hadoop.hive.metastore.client.builder.PartitionBuilder; +import org.apache.hadoop.hive.metastore.client.builder.TableBuilder; +import org.apache.hadoop.hive.metastore.columnstats.cache.LongColumnStatsDataInspector; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; +import org.apache.hadoop.hive.metastore.minihms.AbstractMetaStoreService; +import org.apache.hadoop.hive.metastore.utils.FileUtils; + +import org.apache.thrift.TException; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import com.google.common.collect.Lists; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * Tests for updating partition column stats. + */ +@RunWith(Parameterized.class) +@Category(MetastoreCheckinTest.class) +public class TestPartitionStat extends MetaStoreClientTest { + private AbstractMetaStoreService metaStore; + private IMetaStoreClient client; + private String directSql = "false"; + + protected static final String DB_NAME = "test_part_stat"; + protected static final String TABLE_NAME = "test_part_stat_table"; + private static final String DEFAULT_COL_TYPE = "int"; + private static final String PART_COL_NAME = "year"; + protected static final short MAX = -1; + private static final Partition[] PARTITIONS = new Partition[5]; + public static final String HIVE_ENGINE = "hive"; + + public TestPartitionStat(String name, AbstractMetaStoreService metaStore) { + this.metaStore = metaStore; + } + + @Before + public void setUp() throws Exception { + // Get new client, store the original value of directSql to restore it back after test. + directSql = metaStore.getConf().get(MetastoreConf.ConfVars.TRY_DIRECT_SQL.getVarname()); + client = metaStore.getClient(); + + // Clean up the database + client.dropDatabase(DB_NAME, true, true, true); + metaStore.cleanWarehouseDirs(); + Database db = new DatabaseBuilder(). + setName(DB_NAME). + create(client, metaStore.getConf()); + + // Create test tables with 3 partitions + createTable(TABLE_NAME, getYearPartCol()); + createPartitions(); + + // Hack to initialize the stats tables. Not sure why the first test run using remote metastore is failing with + // error (Unable to update Column stats for table due to: Table/View 'PART_COL_STATS' does not exist.). This hack + // has fixed it. All the tests will be executed first using embedded metastore and then with + // remote metastore. For embedded metastore, TRY_DIRECT_SQL is set to false. For remote metastore TRY_DIRECT_SQL is + // set to true. + client.getPartitionColumnStatistics(DB_NAME, TABLE_NAME, Review comment: My guess is that the autocreate scripts do not create the tables just when there is a DN request for it. Since we are using directSql to get the data the tables are not created. I would guess that we have to create the appropriate tables from `MetaStoreDirectSql.ensureDbInit()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
